Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align sidebar gears to the right #33721

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Align sidebar gears to the right #33721

wants to merge 3 commits into from
+20 −8

Conversation

quentinguidee
Copy link

Currently, the issue/pr sidebar is hard to read visually. One of the reason is that the gear icons make reading difficult because they are "in the way" when reading, and not aligned together.

This PR proposes to align them on the right.

Actions are also better highlighted this way.

Screenshots

Issue

Before this PR After this PR
Capture d’écran 2025-02-25 à 19 59 39 Capture d’écran 2025-02-25 à 19 58 56

Pull Request

Before this PR After this PR
Capture d’écran 2025-02-25 à 20 16 12  Capture d’écran 2025-02-25 à 20 15 54

@quentinguidee
feat: move sidebar gears to the right
3c0ed69 
Signed-off-by: Quentin Guidée <quentin.guidee@gmail.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 25, 2025
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 25, 2025
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Feb 25, 2025
@lunny lunny added this to the 1.24.0 milestone Feb 25, 2025
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Feb 25, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 25, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 25, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 25, 2025
wxiaoguang
wxiaoguang requested changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is a general/common layout, it needs a well-defined style, but not copying a lot of duplicate helper classes.

.ui.dropdown.text-flex-grow {
}
.ui.dropdown.text-flex-grow .text {
}

<div class="ui dropdown text-flex-grow">
</div>

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Feb 26, 2025
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 26, 2025
@GiteaBot @quentinguidee
Merge branch 'main' into feat/move-sidebar-gear-to-the-right
8e660ac 
Signed-off-by: Quentin Guidée <quentin.guidee@gmail.com>
@quentinguidee quentinguidee force-pushed the feat/move-sidebar-gear-to-the-right branch from 0fd3d86 to 8e660ac Compare February 26, 2025 08:15
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 26, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/templates This PR modifies the template files size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
5 participants
@quentinguidee @lunny @wxiaoguang @delvh @GiteaBot